Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Facebook copyrights, update licenses to MIT #7

Closed
wants to merge 1 commit into from
Closed

Remove Facebook copyrights, update licenses to MIT #7

wants to merge 1 commit into from

Conversation

acao
Copy link
Owner

@acao acao commented Jun 11, 2019

  • remove copyright statements from all files
  • update license files to MIT
  • export LICENSE files from all projects
  • update/add package.json license entries
  • normalize import/require formatting across all files

@acao acao force-pushed the update-licenses branch 2 times, most recently from d8983ac to a6e6f61 Compare June 11, 2019 15:30
benjie
benjie requested changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just need to delete any remaining PATENTS files and then it's good to go up the chain for approval 👍

@acao
Remove Facebook copyrights, update licenses to MIT
c95b8f8 
- remove copyright statements from all files
- update license files to MIT
- export LICENSE files from all projects
- update/add package.json license entries
- normalize import/require formatting across all files
- remove PATENTS from codemirror
@acao acao force-pushed the update-licenses branch from a6e6f61 to c95b8f8 Compare June 11, 2019 15:47
@acao
Copy link
Owner Author

acao commented Jun 11, 2019

@benjie thanks !! all the PATENTS files are gone now

benjie
benjie approved these changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@benjie benjie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need approval from GraphQL Foundation; but LGTM 👍

@benjie
Copy link
Collaborator

benjie commented Jun 11, 2019

@leebyron and @caniszczyk; please approve these license changes 👍

@caniszczyk
Copy link

please don't remove copyright headers, just change attribution to "GraphQL Contributors"

@acao
Copy link
Owner Author

acao commented Jun 12, 2019

@caniszczyk can do. I modelled this on Ivans PR you approved here:
https://github.com/graphql/express-graphql/pull/515/files
Does this mean he needs to re-add the copyright headers? Or is it just different for these projects?

@acao
Copy link
Owner Author

acao commented Jun 12, 2019

@caniszczyk was easier to just re-create the branch
#9

@acao acao closed this Jun 12, 2019
@acao acao deleted the update-licenses branch June 12, 2019 19:05
@acao acao mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acao @benjie @caniszczyk