Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)

This reverts commit bacd7f9.

Co-authored-by: spalger <[email protected]>

src/plugins/dashboard/public/application/top_nav/editor_menu.tsx

@@ -231,7 +231,7 @@ export const EditorMenu = ({ dashboardContainer, createNewVisType }: Props) => {
     <SolutionToolbarPopover
       ownFocus
       label={i18n.translate('dashboard.solutionToolbar.editorMenuButtonLabel', {
-        defaultMessage: 'Select type',
+        defaultMessage: 'All types',
       })}
       iconType="arrowDown"
       iconSide="right"

src/plugins/kibana_usage_collection/server/collectors/management/schema.ts

@@ -440,10 +440,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'labs:canvas:byValueEmbeddable': {
-    type: 'boolean',
-    _meta: { description: 'Non-default value of setting.' },
-  },
   'labs:canvas:useDataService': {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },

src/plugins/kibana_usage_collection/server/collectors/management/types.ts

@@ -121,7 +121,6 @@ export interface UsageStats {
   'banners:textColor': string;
   'banners:backgroundColor': string;
   'labs:canvas:enable_ui': boolean;
-  'labs:canvas:byValueEmbeddable': boolean;
   'labs:canvas:useDataService': boolean;
   'labs:presentation:timeToPresent': boolean;
   'labs:dashboard:enable_ui': boolean;

src/plugins/presentation_util/common/labs.ts

@@ -11,9 +11,7 @@ import { i18n } from '@kbn/i18n';
 export const LABS_PROJECT_PREFIX = 'labs:';
 export const DEFER_BELOW_FOLD = `${LABS_PROJECT_PREFIX}dashboard:deferBelowFold` as const;
 export const DASHBOARD_CONTROLS = `${LABS_PROJECT_PREFIX}dashboard:dashboardControls` as const;
-export const BY_VALUE_EMBEDDABLE = `${LABS_PROJECT_PREFIX}canvas:byValueEmbeddable` as const;
-
-export const projectIDs = [DEFER_BELOW_FOLD, DASHBOARD_CONTROLS, BY_VALUE_EMBEDDABLE] as const;
+export const projectIDs = [DEFER_BELOW_FOLD, DASHBOARD_CONTROLS] as const;
 export const environmentNames = ['kibana', 'browser', 'session'] as const;
 export const solutionNames = ['canvas', 'dashboard', 'presentation'] as const;
 
@@ -50,19 +48,6 @@ export const projects: { [ID in ProjectID]: ProjectConfig & { id: ID } } = {
     }),
     solutions: ['dashboard'],
   },
-  [BY_VALUE_EMBEDDABLE]: {
-    id: BY_VALUE_EMBEDDABLE,
-    isActive: true,
-    isDisplayed: true,
-    environments: ['kibana', 'browser', 'session'],
-    name: i18n.translate('presentationUtil.labs.enableByValueEmbeddableName', {
-      defaultMessage: 'By-Value Embeddables',
-    }),
-    description: i18n.translate('presentationUtil.labs.enableByValueEmbeddableDescription', {
-      defaultMessage: 'Enables support for by-value embeddables in Canvas',
-    }),
-    solutions: ['canvas'],
-  },
 };
 
 export type ProjectID = typeof projectIDs[number];

src/plugins/presentation_util/public/components/solution_toolbar/items/quick_group.scss

@@ -1,31 +1,11 @@
 .quickButtonGroup {
-  .euiButtonGroup__buttons {
-    border-radius: $euiBorderRadius;
-
-    .quickButtonGroup__button {
-      background-color: $euiColorEmptyShade;
-      @include kbnThemeStyle('v8') {
-        // sass-lint:disable-block no-important
-        border-width: $euiBorderWidthThin !important;
-        border-style: solid !important;
-        border-color: $euiBorderColor !important;
-      }
-    }
-
-    .quickButtonGroup__button:first-of-type {
-      @include kbnThemeStyle('v8') {
-        // sass-lint:disable-block no-important
-        border-top-left-radius: $euiBorderRadius !important;
-        border-bottom-left-radius: $euiBorderRadius !important;
-      }
-    }
-
-    .quickButtonGroup__button:last-of-type {
-      @include kbnThemeStyle('v8') {
-        // sass-lint:disable-block no-important
-        border-top-right-radius: $euiBorderRadius !important;
-        border-bottom-right-radius: $euiBorderRadius !important;
-      }
+  .quickButtonGroup__button {
+    background-color: $euiColorEmptyShade;
+    @include kbnThemeStyle('v8') {
+      // sass-lint:disable-block no-important
+      border-width: $euiBorderWidthThin !important;
+      border-style: solid !important;
+      border-color: $euiBorderColor !important;
     }
   }
 }

src/plugins/telemetry/schema/oss_plugins.json

@@ -7677,12 +7677,6 @@
             "description": "Non-default value of setting."
           }
         },
-        "labs:canvas:byValueEmbeddable": {
-          "type": "boolean",
-          "_meta": {
-            "description": "Non-default value of setting."
-          }
-        },
         "labs:canvas:useDataService": {
           "type": "boolean",
           "_meta": {

x-pack/plugins/canvas/canvas_plugin_src/expression_types/embeddable.ts

@@ -6,11 +6,12 @@
  */
 
 import { ExpressionTypeDefinition } from '../../../../../src/plugins/expressions';
-import { EmbeddableInput } from '../../types';
+import { EmbeddableInput } from '../../../../../src/plugins/embeddable/common/';
 import { EmbeddableTypes } from './embeddable_types';
 
 export const EmbeddableExpressionType = 'embeddable';
 export { EmbeddableTypes, EmbeddableInput };
+
 export interface EmbeddableExpression<Input extends EmbeddableInput> {
   /**
    * The type of the expression result

x-pack/plugins/canvas/canvas_plugin_src/functions/browser/index.ts

@@ -6,11 +6,21 @@
  */
 
 import { functions as commonFunctions } from '../common';
+import { functions as externalFunctions } from '../external';
 import { location } from './location';
 import { markdown } from './markdown';
 import { urlparam } from './urlparam';
 import { escount } from './escount';
 import { esdocs } from './esdocs';
 import { essql } from './essql';
 
-export const functions = [location, markdown, urlparam, escount, esdocs, essql, ...commonFunctions];
+export const functions = [
+  location,
+  markdown,
+  urlparam,
+  escount,
+  esdocs,
+  essql,
+  ...commonFunctions,
+  ...externalFunctions,
+];

x-pack/plugins/canvas/canvas_plugin_src/functions/external/index.ts

@@ -5,26 +5,9 @@
  * 2.0.
  */
 
-import { EmbeddableStart } from 'src/plugins/embeddable/public';
-import { embeddableFunctionFactory } from './embeddable';
 import { savedLens } from './saved_lens';
 import { savedMap } from './saved_map';
 import { savedSearch } from './saved_search';
 import { savedVisualization } from './saved_visualization';
 
-export interface InitializeArguments {
-  embeddablePersistableStateService: {
-    extract: EmbeddableStart['extract'];
-    inject: EmbeddableStart['inject'];
-  };
-}
-
-export function initFunctions(initialize: InitializeArguments) {
-  return [
-    embeddableFunctionFactory(initialize),
-    savedLens,
-    savedMap,
-    savedSearch,
-    savedVisualization,
-  ];
-}
+export const functions = [savedLens, savedMap, savedVisualization, savedSearch];