Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GetFulfillmentPreview call #711

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fixed GetFulfillmentPreview call #711

merged 1 commit into from
Feb 1, 2024

Conversation

julianpetriv
Copy link
Contributor

It was throwing validation errors as Amazon doesn't accept capitalized json properties

@julianpetriv
Copy link
Contributor Author

Fixes #630 issue

@abuzuhri abuzuhri merged commit fdef2b0 into abuzuhri:main Feb 1, 2024
1 check passed
@abuzuhri
Copy link
Owner

abuzuhri commented Feb 1, 2024

@julianpetriv Do you test this , are you sour its will fix the problem ?

@julianpetriv
Copy link
Contributor Author

@abuzuhri yep I had the same issue as in #630 and the fix worked for me, I tested it

@abuzuhri
Copy link
Owner

abuzuhri commented Feb 1, 2024

Thanks , publish in new nugget version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuzuhri abuzuhri abuzuhri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianpetriv @abuzuhri