Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kSysLogLoggerId defined but not used #743

Merged
merged 1 commit into from
Mar 12, 2020
Merged

kSysLogLoggerId defined but not used #743

merged 1 commit into from
Mar 12, 2020

Conversation

benrubson
Copy link
Contributor

@benrubson benrubson commented Feb 22, 2020 •
edited
Loading

Hi,

This PR follows #620 and b96d489, and fixes the following warning :

‘el::base::consts::kSysLogLoggerId’ defined but not used [-Wunused-variable]
783 static const char* kSysLogLoggerId                         =      "syslog";

It then closes #742.

Thank you 👍

@benrubson benrubson mentioned this pull request Feb 22, 2020
Closed
@benrubson benrubson requested a review from abumq February 22, 2020 09:51
@benrubson benrubson mentioned this pull request Feb 22, 2020
Closed
@benrubson benrubson mentioned this pull request Mar 3, 2020
Merged
@benrubson
Copy link
Contributor Author

@abumusamq do you think we could merge this tiny patch please ?
Thank you very much 👍

@abumq
Copy link
Owner

abumq commented Mar 12, 2020

Thank you for the change, all changes must go to develop branch. could you pleas change that?

@benrubson benrubson changed the base branch from master to develop March 12, 2020 08:11
@benrubson
Copy link
Contributor Author

Thank you for your feedback @abumusamq, I then just moved to develop branch 👍

@abumq abumq merged commit 9532481 into abumq:develop Mar 12, 2020
@benrubson benrubson deleted the warn branch March 12, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abumq abumq Awaiting requested review from abumq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kSysLogLoggerId defined but not used
2 participants
@benrubson @abumq