update puppet::defaults::{facterbasepath,reports_dir}

[Falkor]

Signed-off-by: Sebastien Varrette [email protected]

[toepi]

sry to ask, but why do you think the defaults are wrong? I'm currently migrated some dynamic stuff from hiera as fact and is seem to work with puppet4 and this defaults - think after this pull request we get errors that /etc/puppetlabs/facter does not exists (or it is only on my system the case?)

[Falkor]

my understanding of the puppet 4 locations is that /etc/puppetlabs/* is meant to host the [custom] configuration files (like puppet/puppet.conf, r10k/r10k.yaml etc.) while /opt/puppetlabs hosts wide-system things. We can argue on whether custom facts enter the first or second category, for me it was the first but if that breaks too much workflow with this module, just drop this proposal ;)

[rendhalver]

I understand that the defaults may be different.
I am not arguing about that.
What I am saying is this module uses semantic versioning so I need keep the variables as is and only change them on a major release.
People who use this module are relying on it to manage their infrastructure in a predictable way and I won't release code that will break that.

[toepi]

@Falkor: thanks for this explanation.
@rendhalver: why not as optional parameter? so falkor can use his path and the old user use ours and your rethink it for the next major? For me the migration from 3 to 4 was an nightmare - but not an issue of this module.

[rendhalver]

I am not sure which is actually the correct location.
I am not actually changing the defaults for the two vars you want to edit I am just setting them so I can reference them elsewhere in the code.
From what I have seen these actually work as-is.
Can you show me some error messages that show the locations I am using are actually wrong?