Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep8 lint #82

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Pep8 lint #82

wants to merge 7 commits into from

Conversation

cg-cnu
Copy link

@cg-cnu cg-cnu commented Oct 12, 2017

Fixes #81

@mottosso
Copy link
Member

Thanks for this @cg-cnu. I'm getting a slightly different set of warnings here from my linter (Anaconda, Sublime 3) so I think it's a good opportunity to add linting to the automated test suite here on GitHub.

I'll take a look at that within the coming days.

@cg-cnu
Copy link
Author

cg-cnu commented Oct 13, 2017

@mottosso Sounds fantastic! Let me know if I can be of any help! 😄

@mottosso
Copy link
Member

mottosso commented Oct 13, 2017

Actually, if you'd like, I'd be happy for you to do that. :)

It'd involve setting up Travis, running docker-maya on it, installing and running pylint on it to check for errors. It's a challenge. Let me know. :)

@cg-cnu
Copy link
Author

cg-cnu commented Oct 13, 2017

Wow! Thanks for the offer 🙇 I would be happy to pickup. 😄
I have setup jenkins before but never tried travis and briefly played with docker. So, might need some guidance along the way 🙂

@mottosso
Copy link
Member

Certainly! Have a look at the Qt.py project for inspiration; I'd imagine the set-up to be quite similar.

Notice that I've linked to an older commit, when the Dockerfile and Travis configuration file wasn't so complex. In a nutshell, you can start by pulling mottosso/docker-maya and get the pylint working in there. You'll need to run it via mayapy, initialise Maya and then run it, such that it can gain access to members of maya.cmds and friends.

More inspiration can be found in the Avalon project, which uses the docker-maya project as well.

In this Dockerfile, you can see how it builds upon docker-maya, and adds a custom command to it. In the .travis.yml file, you can see how it's being used. But you can focus on getting a Dockerfile up and running first, and having it run successfully on your local machine first. Once that's done, getting Travis to run it is really straightforward.

Any questions, fire away. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants