NOISSUE- Implement Domains #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuchyri
changed the title
ianmuchyri
force-pushed
the
implementdomains
branch
3 times, most recently
from
ca929c8
to
8521063
Compare
rodneyosodo
requested changes
Nov 30, 2023
rodneyosodo
requested changes
Nov 30, 2023
rodneyosodo
requested changes
Dec 1, 2023
rodneyosodo
requested changes
Dec 1, 2023
I think it's beacuse you are using the wrong branch, hence you have a token which does not have the domain in it |
dborovcanin
requested changes
Dec 1, 2023
There was a problem hiding this comment.
I am not able to reproduce @rodneyosodo's errors, nor problems with users seeing things from other domains. When adding Things, Groups, or Users - I'd expect to see them appear in the list once I successfully submit the request.
rodneyosodo
requested changes
Dec 1, 2023
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {{ range $i, $m := .Members }} |
There was a problem hiding this comment.
This will be solved in another pr, once we are enable to fetch domain members with relations
Signed-off-by: ianmuchyri <[email protected]>
ianmuchyri
force-pushed
the
implementdomains
branch
from
d4bd14d
to
145e91d
Compare
dborovcanin
approved these changes
Dec 1, 2023
Musilah
pushed a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: ianmuchyri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Implement domains into the UI to sync with Magistrala's implementation of domains.
Adds:
Which issue(s) does this PR fix/relate to?
None
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes