MG-177 - Add password visibility eye toggle functionality to magistrala login page #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wambuipixel <[email protected]>
…ate password and reset password pages Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
ianmuchyri
requested changes
Mar 19, 2024
| @@ -51,6 +51,7 @@ <h2>Login</h2> | |||
| id="password" | |||
| placeholder="Password" | |||
There was a problem hiding this comment.
Increase the margin between the input and the eye
to do this you can add a bootstrap class me-2 to the input element. Do this for the envelope in the email-field too and the lock in the password field. They will look sth like
<i class="fas fa-solid fa-envelope me-2"></i>
<i class="fas fa-solid fa-lock me-2"></i>
<input class="p-3 w-100 me-2" type="password" name="password" id="password" placeholder="Password" />
Do this for the other forms as well
ui/web/templates/login.html
Outdated
| .catch((error) => { | ||
| console.error("error submitting login form: ", error); | ||
| }); | ||
| } | ||
| //code for toggling the visibility of the password |
There was a problem hiding this comment.
Suggested change
| //code for toggling the visibility of the password | |
| // Code for toggling the visibility of the password |
There was a problem hiding this comment.
change the other comments as well
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
Musilah
approved these changes
Mar 19, 2024
dborovcanin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Adding an eye visibility toggle function to the login page allowing users to toggle on to see the password and toggle off to not see the password.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Yes
Notes