Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-110 -Resizing of charts #114

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

ianmuchyri
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Dependency Update

What does this do?

Resize charts to sync up with the resizing of the widget.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

  • Yes
  • No, and this is why:

Did you document any new/modified functionality?

  • Yes
  • No, and this is why:

Notes

@ianmuchyri ianmuchyri changed the base branch from main to dashboards February 2, 2024 13:36
@ianmuchyri ianmuchyri marked this pull request as ready for review February 2, 2024 13:39
@ianmuchyri ianmuchyri added the dashboards Dashboards label Feb 2, 2024
@dborovcanin dborovcanin force-pushed the dashboards branch 2 times, most recently from 114644c to 69f93ad Compare February 5, 2024 22:24
Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, the UI dashboard page returns plain JSON content so it's impossible to test. Please fix it, so that we can test.

Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this one, since this is related to #108, and we will send fixes if needed.

@dborovcanin dborovcanin merged commit dfb6136 into absmach:dashboards Feb 6, 2024
dborovcanin pushed a commit that referenced this pull request Feb 9, 2024
* facilitate resizing of charts on the dashboard

Signed-off-by: ianmuchyri <[email protected]>

* remove unused variables

Signed-off-by: ianmuchyri <[email protected]>

* fix error

Signed-off-by: ianmuchyri <[email protected]>

---------

Signed-off-by: ianmuchyri <[email protected]>
dborovcanin pushed a commit that referenced this pull request Feb 9, 2024
* facilitate resizing of charts on the dashboard

Signed-off-by: ianmuchyri <[email protected]>

* remove unused variables

Signed-off-by: ianmuchyri <[email protected]>

* fix error

Signed-off-by: ianmuchyri <[email protected]>

---------

Signed-off-by: ianmuchyri <[email protected]>
dborovcanin pushed a commit that referenced this pull request Feb 9, 2024
* facilitate resizing of charts on the dashboard

Signed-off-by: ianmuchyri <[email protected]>

* remove unused variables

Signed-off-by: ianmuchyri <[email protected]>

* fix error

Signed-off-by: ianmuchyri <[email protected]>

---------

Signed-off-by: ianmuchyri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboards Dashboards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Resizing of widget and chart
2 participants