-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-110 -Resizing of charts #114
Conversation
114644c
to
69f93ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts.
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
283f7cf
to
77774ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, the UI dashboard page returns plain JSON content so it's impossible to test. Please fix it, so that we can test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this one, since this is related to #108, and we will send fixes if needed.
* facilitate resizing of charts on the dashboard Signed-off-by: ianmuchyri <[email protected]> * remove unused variables Signed-off-by: ianmuchyri <[email protected]> * fix error Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: ianmuchyri <[email protected]>
* facilitate resizing of charts on the dashboard Signed-off-by: ianmuchyri <[email protected]> * remove unused variables Signed-off-by: ianmuchyri <[email protected]> * fix error Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: ianmuchyri <[email protected]>
* facilitate resizing of charts on the dashboard Signed-off-by: ianmuchyri <[email protected]> * remove unused variables Signed-off-by: ianmuchyri <[email protected]> * fix error Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: ianmuchyri <[email protected]>
What type of PR is this?
What does this do?
Resize charts to sync up with the resizing of the widget.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes