MG-93 - Add support for creating charts #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Musilah Please resolve the conflicts and mark as Ready for review when it's ready. |
dborovcanin
reviewed
Jan 31, 2024
dborovcanin
force-pushed
the
dashboards
branch
from
1a749a9
to
c0a7326
Compare
ianmuchyri
requested changes
Feb 1, 2024
| @@ -5,15 +5,15 @@ | |||
| "packages": { | |||
| "": { | |||
| "devDependencies": { | |||
| "prettier": "^3.1.0", | |||
There was a problem hiding this comment.
why are you removing the prettier dependency? It's used for prettier formatting
ui/jsonObject.go
Outdated
| @@ -21,59 +21,65 @@ func CreateItem() []Item { | |||
| Widget: "lineChart", | |||
There was a problem hiding this comment.
rename this file to a more descriptive name.
There was a problem hiding this comment.
and remove the to be deleted comment
ui/jsonObject.go
Outdated
| Content: "This is a small sentence about a line chart", | ||
| Image: "https://example.com/image9.jpg", | ||
| Widget: "gauge", | ||
| Widget: "tempGauge", | ||
| }, | ||
| { | ||
| Title: "Line Chart", |
There was a problem hiding this comment.
Line chart is being repeated a couple of times
dborovcanin
force-pushed
the
dashboards
branch
from
c0a7326
to
9743af1
Compare
ianmuchyri
requested changes
Feb 1, 2024
ui/charts.go
Outdated
| { | ||
| Title: "Time Series Line Chart", | ||
| Content: "This is a small sentence about a line chart", | ||
| Image: "https://example.com/image1.jpg", |
There was a problem hiding this comment.
remove the image field if we are not using it. If we are using it, find relevant open source images to use for the images
dborovcanin
force-pushed
the
dashboards
branch
from
9743af1
to
e687f0d
Compare
ianmuchyri
requested changes
Feb 1, 2024
| height: 600, | ||
| }); | ||
| var app = {}; | ||
| const categories = (function () { |
There was a problem hiding this comment.
use var instead of const
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
dborovcanin
requested changes
Feb 1, 2024
Signed-off-by: ianmuchyri <[email protected]>
ianmuchyri
approved these changes
Feb 2, 2024
dborovcanin
approved these changes
Feb 2, 2024
ianmuchyri
added a commit
to ianmuchyri/magistrala-ui
that referenced
this pull request
Feb 2, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Feb 5, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Feb 5, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Feb 9, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Feb 9, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Feb 9, 2024
* add charts support Signed-off-by: Musilah <[email protected]> * add bar and line charts Signed-off-by: Musilah <[email protected]> * add charts subdirectory Signed-off-by: Musilah <[email protected]> * fox service.go Signed-off-by: Musilah <[email protected]> * add dynamicdatachartmodal Signed-off-by: Musilah <[email protected]> * add images to widgets Signed-off-by: Musilah <[email protected]> * add chart widget images Signed-off-by: Musilah <[email protected]> * fix: remove copyright images Signed-off-by: Musilah <[email protected]> * remove comment from code Signed-off-by: ianmuchyri <[email protected]> --------- Signed-off-by: Musilah <[email protected]> Signed-off-by: ianmuchyri <[email protected]> Co-authored-by: ianmuchyri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
This creates chart templates that will be added to the widgets.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
The charts being added include: