Skip to content

Commit

Permalink
MG-56 - Fix unnecessary horizontal scroll (#58)
Browse files Browse the repository at this point in the history
* fix unnecessary scrolling on channel,group,thing

there was a scroll x that was not necessary

Signed-off-by: ianmuchyri <[email protected]>

* remove unnecesary fix

Signed-off-by: ianmuchyri <[email protected]>

---------

Signed-off-by: ianmuchyri <[email protected]>
  • Loading branch information
ianmuchyri authored Dec 28, 2023
1 parent 9d3f997 commit fefb2fc
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.21.0

require (
github.com/absmach/agent v0.0.0-20231107115142-c8b509f24d50
github.com/absmach/magistrala v0.11.1-0.20231217131421-48e971180bb4
github.com/absmach/magistrala v0.11.1-0.20231227115828-e01a82e84b37
github.com/absmach/senml v1.0.5
github.com/caarlos0/env/v9 v9.0.0
github.com/eclipse/paho.mqtt.golang v1.4.3
Expand Down Expand Up @@ -40,8 +40,8 @@ require (
github.com/prometheus/procfs v0.12.0 // indirect
github.com/x448/float16 v0.8.4 // indirect
golang.org/x/net v0.17.0 // indirect
golang.org/x/sys v0.14.0 // indirect
golang.org/x/text v0.13.0 // indirect
golang.org/x/sys v0.15.0 // indirect
golang.org/x/text v0.14.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20231030173426-d783a09b4405 // indirect
google.golang.org/protobuf v1.31.0 // indirect
)
6 changes: 6 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ github.com/absmach/agent v0.0.0-20231107115142-c8b509f24d50 h1:RyDGAkOtIuN34HEJ/
github.com/absmach/agent v0.0.0-20231107115142-c8b509f24d50/go.mod h1:/S3WufAqHTSU6MEq6cN0g6m21RhPX8dxqubYh08vbU8=
github.com/absmach/magistrala v0.11.1-0.20231217131421-48e971180bb4 h1:moYrqFW4bJ7LlGsRvFyJFcBe5KuvjClIdUJz/hF8olg=
github.com/absmach/magistrala v0.11.1-0.20231217131421-48e971180bb4/go.mod h1:ll3GBNSvNs2FJvOdOd3kdlKqbUijFrYzGc0+dji1Pz4=
github.com/absmach/magistrala v0.11.1-0.20231227115828-e01a82e84b37 h1:8uObyxlp9KfsJtumjyFrsOwx1vF3ANHV1/DQkXJYq+c=
github.com/absmach/magistrala v0.11.1-0.20231227115828-e01a82e84b37/go.mod h1:vnzZ/Y6v0L/14BQTUGR9Na+qRXZ3o4l3yyMD1b5nfjk=
github.com/absmach/senml v1.0.5 h1:zNPRYpGr2Wsb8brAusz8DIfFqemy1a2dNbmMnegY3GE=
github.com/absmach/senml v1.0.5/go.mod h1:NDEjk3O4V4YYu9Bs2/+t/AZ/F+0wu05ikgecp+/FsSU=
github.com/afex/hystrix-go v0.0.0-20180502004556-fa1af6a1f4f5/go.mod h1:SkGFH1ia65gfNATL8TAiHDNxPzPdmEL5uirI2Uyuz6c=
Expand Down Expand Up @@ -916,13 +918,17 @@ golang.org/x/sys v0.0.0-20200602225109-6fdc65e7d980/go.mod h1:h1NjWce9XRLGQEsW7w
golang.org/x/sys v0.0.0-20200615200032-f1bc736245b1/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.14.0 h1:Vz7Qs629MkJkGyHxUlRHizWJRG2j8fbQKjELVSNhy7Q=
golang.org/x/sys v0.14.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/sys v0.15.0 h1:h48lPFYpsTvQJZF4EKyI4aLHaev3CxivZmv7yZig9pc=
golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.1-0.20181227161524-e6919f6577db/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.13.0 h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k=
golang.org/x/text v0.13.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
Expand Down
2 changes: 1 addition & 1 deletion ui/web/template/channel.html
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
</tbody>
</table>
<div id="error-message" class="text-danger"></div>
<div class="row mt-3">
<div class="row-mb-3 mt-3">
<form action="/channels/disabled" method="post">
<input
type="hidden"
Expand Down
4 changes: 2 additions & 2 deletions ui/web/template/group.html
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
</tbody>
</table>
<div id="error-message" class="text-danger"></div>
<div class="row mt-3">
<div class="row-mb-3 mt-3">
<form action="/groups/disabled" method="post">
<input type="hidden" name="groupID" id="groupID" value="{{ .Group.ID }}" />
<button
Expand Down Expand Up @@ -138,7 +138,7 @@
button: "save-metadata",
value: parsedMetadata,
});
</script>
</script>
<script type="module">
import { attachEditRowListener, updateName, updateDescription, updateMetadata} from "/js/update.js";

Expand Down
2 changes: 1 addition & 1 deletion ui/web/template/thing.html
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
</tbody>
</table>
<div id="error-message" class="text-danger"></div>
<div class="row mt-3">
<div class="row-mb-3 mt-3">
<form action="/things/disabled" method="post">
<input type="hidden" name="thingID" id="thingID" value="{{ .Thing.ID }}" />
<button
Expand Down

0 comments on commit fefb2fc

Please sign in to comment.