Build type __reference__ values for SDL-generated types #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| @spec import_sdl(String.t() | Macro.t(), [import_sdl_option()]) :: Macro.t() | ||
| defmacro import_sdl(sdl, opts \\ []) do | ||
| do_import_sdl(sdl, opts) | ||
| __CALLER__ | ||
| |> do_import_sdl(sdl, opts) |
There was a problem hiding this comment.
@bruce ah yeah this is definitely the right thing to do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR calculates
__reference__values for types created byimport_sdl/2, with specialized support for the:pathoption (so schema validation errors will reference the source.graphqlfile & line). Various parts of Absinthe assume__reference__is set.Aside: @benwilson512 and I have discussed reassessing how we use
__reference__and__private__(andsource_location, likely), considering some conflation in use.