Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance fixes #1016

Merged
merged 9 commits into from
Jan 2, 2021
Merged

Maintenance fixes #1016

merged 9 commits into from
Jan 2, 2021

Conversation

maartenvanvliet
Copy link
Contributor

I found a couple of small improvements in the code base

  • Remove unused requires
  • Remove unused variables that exposed bugs in type imports/assertion helpers
  • Remove unused files
  • Rename test file so it gets run

binaryseed
binaryseed reviewed Jan 1, 2021
View reviewed changes
Copy link
Contributor

@binaryseed binaryseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/absinthe/pipeline/error_result.ex Show resolved Hide resolved
lib/absinthe/phase/schema/type_imports.ex Outdated Show resolved Hide resolved
lib/absinthe/schema/rule.ex
@@ -1,40 +0,0 @@
defmodule Absinthe.Schema.Rule do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benwilson512 Was this leftover from before Schema phases?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be safely deleted.

@binaryseed binaryseed merged commit 17f72bb into absinthe-graphql:master Jan 2, 2021
@maartenvanvliet maartenvanvliet deleted the various-fixes branch January 2, 2021 21:56
@maartenvanvliet maartenvanvliet mentioned this pull request Jan 24, 2022
Closed
@maartenvanvliet maartenvanvliet mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwilson512 benwilson512 benwilson512 left review comments

@binaryseed binaryseed binaryseed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maartenvanvliet @binaryseed @benwilson512