Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PEP 639 #210

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 11, 2024

Starting PEP 639 support. It would be really nice to validate SPDX (wait for packaging?). I did make sure the incorrect combinations of license-files with non-string license is disallowed.

Close #70. I'm also adding support to SchemaStore's related file in SchemaStore/schemastore#4143.

@henryiii
Copy link
Collaborator Author

@abravalheri assuming we can't depend on packaging? (Especially a version that's not out yet). Maybe the validation of SPDX classifiers should be optional, just like trove classifiers, based on what else is installed?

@henryiii henryiii marked this pull request as ready for review October 12, 2024 03:50
@henryiii henryiii force-pushed the henryiii/feat/pep639 branch 2 times, most recently from 4b47dae to 62d9fac Compare October 12, 2024 05:05
@abravalheri
Copy link
Owner

Thank you very much @henryiii.

Yes I think we will have to wait until a new version of packaging is out and then "soft-validate" the field like it is done with trove-classifiers.

henryiii and others added 2 commits October 15, 2024 10:21
Signed-off-by: Henry Schreiner <[email protected]>
@abravalheri abravalheri merged commit cbfc444 into abravalheri:main Oct 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PEP 639
2 participants