Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper pin from Tomli #1

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Remove upper pin from Tomli #1

merged 1 commit into from
Feb 1, 2022

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Feb 1, 2022

It seems the code is compatible with tomli==2.0.0

@abravalheri
Copy link
Owner

Thank you very much @hukkin.
The main reason why I kept the upper pin was because of 3.6, as you pointed out 2.0 does not seem to impose no backwards incompatible change.

I will update a bit the CI setup and merge this PR shortly.

@hukkin
Copy link
Contributor Author

hukkin commented Feb 1, 2022

👍

3.6 should be no concern because tomli sets python_requires metadata, so pip is smart enough to not install tomli>=2.0.0 on py3.6 interpreters.

@abravalheri abravalheri merged commit ca9722d into abravalheri:main Feb 1, 2022
@hukkin hukkin deleted the patch-1 branch February 1, 2022 15:37
@abravalheri
Copy link
Owner

Thanks for the help @hukkin, I will publish a new version soon.

@abravalheri
Copy link
Owner

abravalheri commented Feb 1, 2022 •
edited
Loading

New v0.3.3 released on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hukkin @abravalheri