Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20923 - AbpCrudPageBase sorting is implemented on SortIndex #20952

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

javedahmedone
Copy link
Contributor

@javedahmedone javedahmedone commented Oct 2, 2024

AbpCrudPageBase is sorting by SortIndex is implementd

Resolves#20923 (AbpCrudPageBase is not sorting by SortIndex )

Sorting is implemented in AbpCrudPageBase class on OnDataGridReadAsync with order by sortIndex

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@javedahmedone javedahmedone changed the title #20923 - AbpCrudPageBase is sorting by SortIndex #20923 - AbpCrudPageBase sorting is implemented on SortIndex Oct 2, 2024
@javedahmedone
Copy link
Contributor Author

Hi @gterdem , Can you please review this PR

@maliming maliming added this to the 9.0-preview milestone Oct 4, 2024
@maliming maliming merged commit 22ee4f2 into abpframework:dev Oct 4, 2024
2 checks passed
@maliming
Copy link
Member

maliming commented Oct 4, 2024

Thanks @javedahmedone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants