Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new.abp.io page's title and descriptions updates #20726

Merged
merged 8 commits into from
Sep 25, 2024
Merged

new.abp.io page's title and descriptions updates #20726

merged 8 commits into from
Sep 25, 2024

Conversation

dgnyldrm7
Copy link
Contributor

Related 4299

@dgnyldrm7 dgnyldrm7 added this to the 9.0-preview milestone Sep 4, 2024
@salihozkara salihozkara requested review from oykuermann and removed request for salihozkara September 4, 2024 08:10
@dgnyldrm7 dgnyldrm7 marked this pull request as draft September 4, 2024 12:47
@dgnyldrm7 dgnyldrm7 marked this pull request as ready for review September 11, 2024 10:53
salihozkara
salihozkara requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@salihozkara salihozkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the key whose contents you are changing is not used elsewhere. Or create a new key

abp_io/AbpIoLocalization/AbpIoLocalization/Base/Localization/Resources/en-GB.json Outdated Show resolved Hide resolved
abp_io/AbpIoLocalization/AbpIoLocalization/Base/Localization/Resources/en.json Outdated Show resolved Hide resolved
abp_io/AbpIoLocalization/AbpIoLocalization/Www/Localization/Resources/en.json Outdated Show resolved Hide resolved
oykuermann
oykuermann requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for https://github.com/volosoft/vs-internal/pull/4660#issuecomment-2348666650

@oykuermann oykuermann merged commit f794909 into dev Sep 25, 2024
2 checks passed
@oykuermann oykuermann deleted the dogan/4299 branch September 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oykuermann oykuermann oykuermann approved these changes

@salihozkara salihozkara salihozkara approved these changes

Assignees
No one assigned
Labels
abp-io
Projects
None yet
Milestone
9.0-preview
Development

Successfully merging this pull request may close these issues.
3 participants
@dgnyldrm7 @salihozkara @oykuermann