Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular - Permission Tree Selection Hierarchical Fix #20598

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

sumeyyeKurtulus
Copy link
Contributor

Description

Resolves #20505

Here is a record showing the related fix
PermissionTree

Checklist

  • I fully tested it as developer / designer and created unit / integration tests

How to test it?

  • You can copy the changes to the template modules and test any modal that has permission selection as can be seen in the video.

Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If user selects a main permission, sub-permission should not be selected. The main permissions are the permission to view related pages.

  • If user selects a sub-permission, main permission should be selected.

  • If user deselects the main permission, sub-permissions should be deselected.

  • If user deselects the sub-permission, main permissions should not deselect.

image

@oykuermann
Copy link
Contributor

MVC:

screencast-localhost_44357-2024.08.webm

@masum-ulu
Copy link
Member

@sumeyyeKurtulus it shouldn't select all child permission when the select root like User management checkbox in tree. It must be like MVC example

@sumeyyeKurtulus
Copy link
Contributor Author

@sumeyyeKurtulus it shouldn't select all child permission when the select root like User management checkbox in tree. It must be like MVC example

If you mean that selecting Edit should not also select the User Management permission, this would break the parent selection in the second item above.

Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check after changes:
image

@oykuermann oykuermann merged commit c5e2c58 into rel-8.2 Sep 3, 2024
3 checks passed
@oykuermann oykuermann deleted the issue-20505 branch September 3, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants