Use DbFunction for global query filters. #20065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #20062
SELECT * FROM [AppBooks] AS [a] WHERE (@__ef_filter__p_0 = CAST(1 AS bit) OR [a].[IsDeleted] = CAST(0 AS bit)) AND (@__ef_filter__p_1 = CAST(1 AS bit) OR [a].[TenantId] = @__ef_filter__CurrentTenantId_2) AND (@__ef_filter__p_3 = CAST(1 AS bit) OR [a].[IsActive] = CAST(1 AS bit))
The generated SQL doesn't change when the filter is disabled/enabled, only the variables are changed
(@__ef_filter__p_0 = CAST(1 AS bit) OR [a].[IsDeleted] = CAST(0 AS bit)) AND (@__ef_filter__p_1 = CAST(1 AS bit) OR [a].[TenantId] = @__ef_filter__CurrentTenantId_2) AND (@__ef_filter__p_3 = CAST(1 AS bit) OR [a].[IsActive] = CAST(1 AS bit))
may causing high CPU usage.After this PR, The SQL is now more precise(tested in MySQL, PostgreSQL, SQLite).