Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AbpRedisCahce #20024

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Enhance AbpRedisCahce #20024

merged 1 commit into from
Jun 13, 2024

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Jun 13, 2024

Description

Resolves #20019

Align RedisCache

add "force reconnect" pattern via OnRedisError, opt-in based on new UseForceReconnect option (defaults to false)
avoid thread-race problems by having Connect[Async] return the cache, rather than relying on field
avoid thread-race problems by only using a single ref field (cache), rather than cache+muxer; access muxer indirectly (it is only ever needed to shut down)
use more efficient key-prefix path via RedisKey.Append
use more efficient hash-fetch by pre-storing the hash-key arrays

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 64 lines in your changes missing coverage. Please review.

Project coverage is 52.09%. Comparing base (84396c2) to head (5857f65).
Report is 262 commits behind head on dev.

Files Patch % Lines
...lo/Abp/Caching/StackExchangeRedis/AbpRedisCache.cs 16.21% 61 Missing and 1 partial ⚠️
...p/Caching/StackExchangeRedis/AbpRedisExtensions.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20024      +/-   ##
==========================================
+ Coverage   51.69%   52.09%   +0.40%     
==========================================
  Files        3113     3107       -6     
  Lines       99676    99366     -310     
  Branches     7954     7514     -440     
==========================================
+ Hits        51525    51763     +238     
+ Misses      46598    46044     -554     
- Partials     1553     1559       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming merged commit f567851 into dev Jun 13, 2024
4 of 5 checks passed
@maliming maliming deleted the abprediscache branch June 13, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance AbpRedisCahce
2 participants