SignInManager Checks IdentityOptions in AccountController Login #19745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we need to use settings to set "IdentitySettingNames.SignIn.RequireConfirmedEmail" to true.
these are our settings:
If the user tries to login and the email is not confirmed, the result should be failed.
Everything is good in the admin (/Account/Login) view. If the user is not confirmed, give me the message "You are not allowed to login! Your account is inactive or needs to confirm your email/phone number."
The issue is in Swagger (/api/account/login) endpoint. If the user is not confirmed, the login succeeds!
What we found is that the issue lies in the AccountController.Login where the SignInManager does not read the IdentityOptions. we should add code to read the IdentityOptions in SignInManager:
Please check the pull request to see if there is an issue or if we need to follow a step to bypass this issue.