Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reindex problem #19701

Merged
merged 5 commits into from
May 8, 2024
Merged

Fix reindex problem #19701

merged 5 commits into from
May 8, 2024

Conversation

salihozkara
Copy link
Member

@salihozkara salihozkara commented May 3, 2024 •
edited
Loading

Description

Resolves https://github.com/volosoft/vs-internal/issues/4175

  • As the count of documents increases, the problems with memory increase. Pagination has been added to prevent this.
  • When indexing, the last cached document should be indexed as unique

@salihozkara salihozkara added this to the 8.3-preview milestone May 3, 2024
@salihozkara salihozkara marked this pull request as draft May 3, 2024 11:34
@salihozkara salihozkara marked this pull request as ready for review May 3, 2024 13:03
oykuermann
oykuermann requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no results:
image

fearlesshann
fearlesshann reviewed May 7, 2024
View reviewed changes
Copy link

@fearlesshann fearlesshann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oykuermann oykuermann merged commit 2a96ff6 into dev May 8, 2024
3 checks passed
@oykuermann oykuermann deleted the salihozkara/fixDocsReIndexProblem branch May 8, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearlesshann fearlesshann fearlesshann left review comments

@oykuermann oykuermann oykuermann approved these changes

@realLiangshiwei realLiangshiwei realLiangshiwei approved these changes

Assignees
No one assigned
Labels
abp-module-docs
Projects
None yet
Milestone
8.3-preview
Development

Successfully merging this pull request may close these issues.
4 participants
@salihozkara @realLiangshiwei @fearlesshann @oykuermann