Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #19665

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ceddy4395
Copy link

Description

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Avoid jobs without timeouts
  • Use commit hash instead of tags for action versions
  • Use names for run steps
  • Avoid workflows without comments
  • Avoid incorrectly indented workflows
  • Steps should only perform a single command
  • Avoid installing packages without version

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

- Avoid jobs without timeouts
- Use commit hash instead of tags for action versions
- Use names for run steps
- Avoid workflows without comments
- Avoid incorrectly indented workflows
- Steps should only perform a single command
- Avoid installing packages without version

Signed-off-by: Cedric Willekens <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

@sturlath
Copy link
Contributor

sturlath commented May 1, 2024

@ceddy4395
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants