Angular - Account Pages Sidebar Flicker on Reload #19413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masum-ulu
reviewed
Mar 25, 2024
masum-ulu
reviewed
Mar 25, 2024
npm/ng-packs/packages/core/src/lib/components/dynamic-layout.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
reviewed
Mar 25, 2024
npm/ng-packs/packages/core/src/lib/components/dynamic-layout.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
reviewed
Mar 25, 2024
...s/packages/theme-basic/src/lib/components/application-layout/application-layout.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
approved these changes
Mar 26, 2024
oykuermann
requested changes
Mar 27, 2024
|
Hello again @oykuermann I have added a new condition to render the layout and manage the issue mentioned above #17061 |
masum-ulu
approved these changes
Mar 28, 2024
oykuermann
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #19038 and relates #17061.
As another issue was fixed by #17061, the code piece added inside the
ngOnInitlifecycle hook breaks the account pages and results in a flicker on reload. That is why, we have commented out the related part to propose a solution.SidebarFlickerResolved.webm
Checklist
How to test it?
You can test it by following the instructions as declared in the issue.