Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for videocourses #19223

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Update docs for videocourses #19223

merged 6 commits into from
Mar 11, 2024

Conversation

honurbu
Copy link
Contributor

@honurbu honurbu commented Mar 6, 2024

Used In => https://github.com/volosoft/vs-internal/pull/3866

Video course link added to documentation (rel-8.0)

@honurbu @denizdemirkan
Update docs for videocourses
a64b320 
Co-Authored-By: Deniz Demirkan <[email protected]>
@honurbu honurbu added this to the 8.2-preview milestone Mar 6, 2024
@honurbu honurbu requested a review from salihozkara March 6, 2024 09:29
@honurbu honurbu self-assigned this Mar 6, 2024
@gizemmutukurt gizemmutukurt requested review from oykuermann and removed request for gizemmutukurt March 6, 2024 11:14
oykuermann
oykuermann requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for: https://github.com/volosoft/vs-internal/pull/3866#pullrequestreview-1919815748

@oykuermann
Copy link
Contributor

oykuermann commented Mar 8, 2024 •
edited by honurbu
Loading

image

  • There is two part-1.

Blazor&Angular Authorization page doesn't have video link:

  • /latest/UI/Blazor/Authorization

  • /latest/UI/Blazor/Authorization
    image

  • /latest/UI/Angular/Localization

  • /latest/UI/AspNetCore/JavaScript-API/Localization

  • /latest/UI/Angular/Localization

pages do not have localization links.
image

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 32.9%, saving 516.40 KB.

Filename Before After Improvement Visual comparison
docs/en/Blog-Posts/2023-03-15-Migration-Mssql-Postgresql/images/db-converter.jpg 81.01 KB 79.95 KB -1.3% View diff
docs/en/Community-Articles/2023-03-15-Migration-Mssql-Postgresql/images/db-converter.jpg 81.01 KB 79.95 KB -1.3% View diff
docs/en/Community-Articles/2024-03-02-Using-Testcontainers-In-ABP-Unit-Test/efcore.png 686.72 KB 429.24 KB -37.5% View diff
docs/en/Community-Articles/2024-03-02-Using-Testcontainers-In-ABP-Unit-Test/mongodb.png 685.81 KB 431.90 KB -37.0% View diff
framework/test/Volo.Abp.Imaging.Abstractions.Tests/Volo/Abp/Imaging/Files/abp.webp 33.92 KB 31.03 KB -8.5% View diff

1746 images did not require optimisation.

@honurbu honurbu force-pushed the issue-3458-docs8 branch 2 times, most recently from 21c8ce8 to a64b320 Compare March 11, 2024 08:38
@honurbu @denizdemirkan
Added youtube link some docs
6c1c02f 
Co-Authored-By: Deniz Demirkan <[email protected]>
@honurbu honurbu requested a review from oykuermann March 11, 2024 09:27
@oykuermann oykuermann merged commit 91d83de into rel-8.0 Mar 11, 2024
2 checks passed
@oykuermann oykuermann deleted the issue-3458-docs8 branch March 11, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oykuermann oykuermann oykuermann approved these changes

@salihozkara salihozkara salihozkara approved these changes

Assignees

@honurbu honurbu

Labels
documentation enhancement
Projects
None yet
Milestone
8.2-preview
Development

Successfully merging this pull request may close these issues.
4 participants
@honurbu @oykuermann @CLAassistant @salihozkara