Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DTO code generation for C# static proxy #19145

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix DTO code generation for C# static proxy #19145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651e688
Fix DTO code generation for C# static proxy
realLiangshiwei Feb 27, 2024
879e08b
Update CSharpServiceProxyGenerator.cs
maliming Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,11 +553,16 @@
var s2 = s1[i].Split(",");
for (var x = 0; x < s2.Length; x++)
{
type.Append(s2[x].Split(".").Last());
var s3 = s2[x].Split(".").Last();
type.Append(s3);

Check warning on line 557 in framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs#L556-L557 

Added lines #L556 - L557 were not covered by tests
if (x < s2.Length - 1)
{
type.Append(", ");
}
else if(!s3.Contains(">"))
{
type.Append("<");
}

Check warning on line 565 in framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs#L563-L565 

Added lines #L563 - L565 were not covered by tests
}
}
else
Expand Down
Loading