Add ObjectHelper support for property resolution for nullable value types #18970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
... I'm not sure why the worflow failed, locally all tests pass...
|
maliming
reviewed
Feb 8, 2024
Comment on lines
+42
to
+45
| case ExpressionType.Convert: { | ||
| memberExpression = propertySelector.Body.As<UnaryExpression>().Operand as MemberExpression; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Can you share some test code to cover this case?
There was a problem hiding this comment.
I've integrated the test to cover the explicit case.
namtab00
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #18970 +/- ##
==========================================
- Coverage 51.68% 51.68% -0.01%
==========================================
Files 3092 3092
Lines 98045 98080 +35
Branches 7819 7820 +1
==========================================
+ Hits 50671 50689 +18
- Misses 45823 45838 +15
- Partials 1551 1553 +2 ☔ View full report in Codecov by Sentry. |
maliming
approved these changes
Feb 9, 2024
|
Thanks @namtab00 |
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm using an overriding AuditPropertySetter, that sets a
long CreatorId(defined on new entity interfaces, not IMust/MayHaveCreator).With this setup, ObjectHelper.TrySetProperty did not set that property, due to the member selector expression pointing to a value type.
This PR adds retro-compatible support for such an expression, with no breaking changes.
Checklist
How to test it?
Created specific unit test.