Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group11 Enable nullable annotations #17303

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Group11 Enable nullable annotations #17303

merged 9 commits into from
Aug 9, 2023

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Aug 7, 2023

Description

Related: #16610

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@hikalkan
Copy link
Member

hikalkan commented Aug 9, 2023

Should we merge this?

@maliming
Copy link
Member

maliming commented Aug 9, 2023

The CI check failed. I will re-run it, and merge it when it succeeds.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #17303 (3e3d640) into dev (5c20769) will decrease coverage by 0.02%.
Report is 49 commits behind head on dev.
The diff coverage is 45.63%.

@@            Coverage Diff             @@
##              dev   #17303      +/-   ##
==========================================
- Coverage   53.32%   53.30%   -0.02%     
==========================================
  Files        3016     3016              
  Lines       94001    94001              
==========================================
- Hits        50122    50107      -15     
- Misses      43879    43894      +15     
Files Changed Coverage Δ
...o/Abp/Application/Dtos/AuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...plication/Dtos/CreationAuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...ication/Dtos/ExtensibleAuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...Dtos/ExtensibleCreationAuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...ion/Dtos/ExtensibleFullAuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...p/Application/Dtos/FullAuditedEntityWithUserDto.cs 0.00% <0.00%> (ø)
...ntracts/Volo/Abp/Application/Dtos/ListResultDto.cs 50.00% <ø> (ø)
...ntities/Events/Distributed/EtoMappingDictionary.cs 100.00% <ø> (ø)
...bp/DependencyInjection/MultiTenantDbContextType.cs 94.11% <ø> (ø)
.../Entities/Auditing/AuditedAggregateRootWithUser.cs 0.00% <0.00%> (ø)
... and 34 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maliming maliming merged commit 7e03f4b into dev Aug 9, 2023
2 of 4 checks passed
@realLiangshiwei realLiangshiwei deleted the liangshiwei/group11 branch August 9, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants