Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group8 Enable nullable annotations #17109

Merged
merged 14 commits into from
Jul 13, 2023
Merged

Group8 Enable nullable annotations #17109

merged 14 commits into from
Jul 13, 2023

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Jul 13, 2023

Description

Related: #16610

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #17109 (e5df488) into dev (3ab1db1) will increase coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              dev   #17109      +/-   ##
==========================================
+ Coverage   53.14%   53.19%   +0.04%     
==========================================
  Files        3005     3005              
  Lines       93707    93707              
==========================================
+ Hits        49797    49843      +46     
+ Misses      43910    43864      -46     
Impacted Files Coverage Δ
.../BackgroundJobs/BackgroundJobExecutionException.cs 0.00% <0.00%> (ø)
.../BackgroundWorkers/PeriodicBackgroundWorkerBase.cs 0.00% <ø> (ø)
...s/Volo/Abp/BackgroundJobs/BackgroundJobExecuter.cs 67.85% <50.00%> (ø)
...o/Abp/BackgroundJobs/BackgroundJobNameAttribute.cs 70.58% <100.00%> (ø)
...dJobs/Volo/Abp/BackgroundJobs/BackgroundJobInfo.cs 100.00% <100.00%> (ø)
.../Abp/BackgroundJobs/DefaultBackgroundJobManager.cs 91.89% <100.00%> (ø)
...o/Abp/BackgroundJobs/InMemoryBackgroundJobStore.cs 36.36% <100.00%> (ø)
...Volo/Abp/BackgroundWorkers/BackgroundWorkerBase.cs 95.83% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@realLiangshiwei realLiangshiwei changed the title Liangshiwei/group8 Group8 Enable nullable annotations Jul 13, 2023
@maliming maliming merged commit 56e28da into dev Jul 13, 2023
@realLiangshiwei realLiangshiwei deleted the liangshiwei/group8 branch July 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants