Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/nexB/vulnerablecode/issues/725 #726

Merged
merged 1 commit into from
May 9, 2022
Merged

https://github.com/nexB/vulnerablecode/issues/725 #726

merged 1 commit into from
May 9, 2022

Conversation

markrouz
Copy link

@markrouz markrouz commented May 6, 2022

No description provided.

@markrouz markrouz mentioned this pull request May 6, 2022
Closed
@TG1999
Copy link
Contributor

TG1999 commented May 6, 2022 •
edited
Loading

Hey @markrouz , thanks for this, can you add some tests and also sign off the commit, DCO is failing

@markrouz markrouz force-pushed the main branch 4 times, most recently from 56537b5 to 86faba3 Compare May 6, 2022 17:59
@markrouz
Copy link
Author

markrouz commented May 6, 2022

Hey @markrouz , thanks for this, can you add some tests and also sign off the commit, DCO is failing

@TG1999 thanks for pointing this out. Done

Infinite loop fix
2aede6f 
Signed-off-by: mark <[email protected]>
TG1999
TG1999 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @pombredanne please have a look here once

pombredanne
pombredanne approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks you ++

@TG1999 TG1999 merged commit 75b2920 into aboutcode-org:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 approved these changes

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markrouz @TG1999 @pombredanne