Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate redhat importer #719

Merged
merged 1 commit into from
May 13, 2022
Merged

Migrate redhat importer #719

merged 1 commit into from
May 13, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented May 3, 2022

Signed-off-by: Tushar Goel [email protected]

@TG1999 TG1999 force-pushed the migration/red_hat branch 3 times, most recently from a73a683 to 25fbd09 Compare May 3, 2022 17:33
@TG1999 TG1999 linked an issue May 3, 2022 that may be closed by this pull request
redhat importer - improver migration #718
Closed
@TG1999 TG1999 force-pushed the migration/red_hat branch 2 times, most recently from 5a82321 to 5279666 Compare May 4, 2022 16:06
pombredanne
pombredanne requested changes May 4, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I posted a few review comments,
The key thing is to make sure we do not skip over data silently without logging.

@TG1999 TG1999 force-pushed the migration/red_hat branch 7 times, most recently from 5bba7d7 to b6a10ed Compare May 11, 2022 12:19
pombredanne
pombredanne approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Just a few minor comments

vulnerabilities/importers/redhat.py Show resolved Hide resolved
vulnerabilities/importers/redhat.py Show resolved Hide resolved
vulnerabilities/importers/redhat.py Outdated Show resolved Hide resolved
@TG1999 TG1999 mentioned this pull request May 13, 2022
Open
@TG1999
Copy link
Contributor Author

TG1999 commented May 13, 2022 •
edited
Loading

Thanks @pombredanne , while I was at it, I realised severities were not displayed on UI, also fixed that. Merging it as soon it's all green!
Screenshot from 2022-05-13 23-06-20

@TG1999 TG1999 force-pushed the migration/red_hat branch 2 times, most recently from ae26ec3 to d3316ae Compare May 13, 2022 17:38
@TG1999
Migrate redhat importer
4a5f320 
Fix severities in UI

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 merged commit 360754f into aboutcode-org:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redhat importer - improver migration
2 participants
@TG1999 @pombredanne