Fix deprecated Django API #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmi
force-pushed
the
fix_django_ugettext_lazy_deprecation
branch
from
0a3d16a
to
e33274a
Compare
|
@yilmi we are just missing a DCO signoff |
Signed-off-by: Yassine Ilmi <[email protected]>
yilmi
force-pushed
the
fix_django_ugettext_lazy_deprecation
branch
from
e33274a
to
7fc4731
Compare
Thanks, I missed it, should be fixed now 👍 |
|
Just in case, it seems that you need to approve the workflow again 😅 |
|
@yilmi I am not sure that |
|
Now this is pretty minor change, so I will not bug you more with this! |
pombredanne
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The application can be started in it's current state because ugettext_lazy was deprecated. See https://forum.djangoproject.com/t/importerror-cannot-import-name-ugettext-lazy-from-django-utils-translation/10943
Fix:
Replaced deprecated API with supported one
This Fixes #587 (actually, only the use of an API deprecated in Django 4.x)