Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker docs #521

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Add docker docs #521

merged 2 commits into from
Aug 2, 2021

Conversation

Hritik14
Copy link
Collaborator

This is a part of 1ab0b28
Totally my mistake to leave this file out.

Signed-off-by: Hritik Vijay [email protected]

@Hritik14 Hritik14 force-pushed the docker-docs branch 5 times, most recently from 01e0e24 to 4b303e5 Compare July 28, 2021 20:50
This is a part of 1ab0b28

Signed-off-by: Hritik Vijay <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! feel free to add the few suggested nits and please merge

Explicitly mention that serving VulnerableCode on a network  could be
security issue and there are several steps that may be needed to secure
such a deployment.
Further, a quick tl;dr to run with docker in readme is added for
convenience.

Signed-off-by: Hritik Vijay <[email protected]>
@Hritik14 Hritik14 merged commit 7d3df72 into aboutcode-org:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants