Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort imports #476

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Sort imports #476

merged 3 commits into from
Feb 13, 2022

Conversation

Hritik14
Copy link
Collaborator

Sorting imports has been an unwritten coding style of our codebase. This PR makes it into a test rule.

There are some alternatives to this way of sorting

@sbs2001
Copy link
Collaborator

sbs2001 commented Jun 13, 2021

Couple of things:

  1. One import per line (@pombredanne ^)
  2. I dunno, but I can see lot of imports which we don't use anymore, maybe we could eliminate those ?
  3. In any case this would be merged after we don't have so many PRs, this could conflict with every other PR.

@pombredanne
Copy link
Member

@Hritik14 this is creating a merge "wall" for all other pending PR, so I would rather do this at once when all the pending PRs have been merged first.
Also we would want to add checks in the CI for this and black too.

Sorting imports has been an unwritten coding style of our codebase. This
commit makes it into a test rule.

Signed-off-by: Hritik Vijay <[email protected]>
Signed-off-by: Hritik Vijay <[email protected]>
Signed-off-by: Hritik Vijay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants