Fixes #312 : Added solution for ModuleNotFoundError #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pushpit <[email protected]>
Pushpit07
changed the title
sbs2001
requested changes
Apr 5, 2021
README.rst
Outdated
| @@ -106,6 +106,12 @@ compose. For this you need to have the following installed. | |||
| Use ``sudo docker-compose up`` to start VulnerableCode. Then access | |||
| VulnerableCode at http://localhost:8000/ or at http://127.0.0.1:8000/ | |||
|
|
|||
| If you run into a ``ModuleNotFoundError: No module named '<module>'``, run:: | |||
There was a problem hiding this comment.
let's make this more general.
The root cause of problem here is that after upgrading the code, the docker setup is not synced ie new migrations, deps are not applied.
So a better solution to fix all such problems would be to do
sudo docker-compose up -d --no-deps --build web
So I would change this to something like
Don't forget to run `sudo docker-compose up -d --no-deps --build web` to sync your instance after every `git pull`.
There was a problem hiding this comment.
oh, great. Running this will sync the docker environment each time the codebase updates
Signed-off-by: Pushpit <[email protected]>
sbs2001
reviewed
Apr 5, 2021
README.rst
Outdated
| @@ -106,6 +106,9 @@ compose. For this you need to have the following installed. | |||
| Use ``sudo docker-compose up`` to start VulnerableCode. Then access | |||
| VulnerableCode at http://localhost:8000/ or at http://127.0.0.1:8000/ | |||
|
|
|||
| **Important**: Don't forget to run `sudo docker-compose up -d --no-deps --build web` to sync your instance after every `git pull`. | |||
There was a problem hiding this comment.
You need to enclose the command in 2 tildes
Signed-off-by: Pushpit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commands to run in case of running into a ModuleNotFoundError
Signed-off-by: Pushpit [email protected]