Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rename vuln_references to references #377

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

imnitishng
Copy link
Contributor

Closes #376

@sbs2001
Copy link
Collaborator

sbs2001 commented Mar 15, 2021

@imnitishng thanks for the PR, could you rebase this wtih latest main branch ?

Copy link
Collaborator

@sbs2001 sbs2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Could you please update the Advisory definition in the docs at https://github.com/nexB/vulnerablecode/blob/main/docs/how-to-guides/add_new_importer.rst . Sorry for not mentioning this earlier.

@sbs2001
Copy link
Collaborator

sbs2001 commented Mar 15, 2021

@imnitishng Never mind you changed the docs already :)

@sbs2001 sbs2001 merged commit ff08fd6 into aboutcode-org:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename vuln_references field in Advisory dataclass and refactor it.
2 participants