Improve error handling and other misc. updates #267
Conversation
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Remove HTML format tags Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
- Capture errors and keep trucking - log errors with actual trigger data and full traceback Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Otherwise this fails to run the tests entirely. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Until we have a fix, we should disbale this. Signed-off-by: Philippe Ombredanne <[email protected]>
| @@ -0,0 +1,206 @@ | |||
| VulnerableCode | |||
There was a problem hiding this comment.
Thank you for ReSTification. Why have both README.md and README.rst ? Also they both don't look same. I don't care about alignment but please make the GIF work :)
There was a problem hiding this comment.
I need to remove the README.md.
There was a problem hiding this comment.
But I also need the gif to be in the repo to make things work.... this https://user-images.githubusercontent.com/28975399/89056138-2c8a8300-d379-11ea-882e-f28f38789cdc.png is not right
There was a problem hiding this comment.
and this is done now.
| 'etags': {} | ||
| }, | ||
| }, | ||
| # { |
| >>> repo = meta.getOvalRepositoryInformation() | ||
| >>> repo.setMinimumSchemaVersion("5.9") | ||
| >>> tree.write("outfilename.xml", UTF-8", True) | ||
| >> meta = definition.getMetadata() |
There was a problem hiding this comment.
I don't have any preferences here, either of them is fine by me. Is there a reason you go with >> ?.
There was a problem hiding this comment.
Yes this is to avoid pytest treating these as real doctests and failing since these are not meant to be passing code
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
changed the title
This PR improves error handling and logging when running importers.
It also does a few unrelated misc. updates:
Signed-off-by: Philippe Ombredanne [email protected]