Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segregate PackageRelatedVulnerability model to new models #1612

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Segregate PackageRelatedVulnerability model to new models #1612

merged 8 commits into from
Oct 22, 2024

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Oct 11, 2024 •
edited
Loading

Closes: #966

@TG1999 TG1999 marked this pull request as draft October 11, 2024 10:59
@TG1999
Add new models
30fc2b8 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Fix migrations
1440d69 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Fix API
7f17b45 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Fix migrations order
3d5f8d0 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Fix tests
e412d13 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Fix failing tests
455e3cb 
Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 marked this pull request as ready for review October 15, 2024 12:12
@TG1999 TG1999 requested a review from ziadhany October 15, 2024 15:05
@TG1999 TG1999 mentioned this pull request Oct 15, 2024
Closed
keshav-space
keshav-space approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, LGTM!

ziadhany
ziadhany approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @TG1999. Please go ahead and merge it.

@TG1999 TG1999 merged commit feab9fd into main Oct 22, 2024
9 checks passed
@TG1999 TG1999 deleted the new-models branch October 22, 2024 06:03
@pombredanne pombredanne mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshav-space keshav-space keshav-space approved these changes

@ziadhany ziadhany ziadhany approved these changes

Assignees
No one assigned
Labels
2-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make models better for efficient queries
3 participants
@TG1999 @ziadhany @keshav-space