-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve export command #1571
Merged
Merged
Improve export command #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with usage in FederatedCode, PurlDB and VulnerableCode Signed-off-by: Philippe Ombredanne <[email protected]>
Use the more accurate affected_by_vulnerabilities Create an alias to ensure compatbility Signed-off-by: Philippe Ombredanne <[email protected]>
Use a single queryset Signed-off-by: Philippe Ombredanne <[email protected]>
This is the CWE-prefixed value that we want to commonly display. Signed-off-by: Philippe Ombredanne <[email protected]>
In PackageQuerySet - Align processing in for_purls and for_purl manager methods - Correctly reference Package and not Vulnerability Signed-off-by: Philippe Ombredanne <[email protected]>
- Improve memroy usage of main querysets - Do not leak internal ids in serialized data - Work towards reusing serializers Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
improved-export-command
branch
from
August 27, 2024 10:58
7aed3f3
to
43611f1
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
We use the main docker instead Signed-off-by: Philippe Ombredanne <[email protected]>
And also license-expression, packageurl and cwe2 Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1579 Reported-by: tdruez <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@keshav-space do you mind to look into this? this is needed for FederatedCode |
This was referenced Sep 11, 2024
keshav-space
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pombredanne, LGTM!
The docs build is failing on URL validation. I am merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the "export" command for FederatedCode
This is ready for review. I will likely use Serializers in the future
This also fixes #1579