Add curl advisories importer #1439

ambuj-1211 · 2024-03-17T20:17:42Z

This pr resolves the issue #1166.
The advisories were added properly and the site was working fine. I also registered the importer in the init.py file.

ambuj-1211 · 2024-03-17T20:19:47Z

@TG1999 please let me know if there are any further changes and everything is correct or not.

ziadhany

@ambuj-1211 This is a good start but try to make use of all available data ex: details, CWE , ..

vulnerabilities/tests/test_curl.py

vulnerabilities/importers/curl.py

ambuj-1211 · 2024-03-31T07:43:38Z

on it

ambuj-1211 · 2024-04-07T21:27:23Z

@ziadhany @TG1999 Done with the changes as mentioned.

ziadhany

@ambuj-1211 Nice work! just a few nits for your consideration.

vulnerabilities/tests/test_curl.py

vulnerabilities/importers/curl.py

ziadhany · 2024-04-09T22:56:19Z

@ambuj-1211 please add a curl improver to the valid_versions.py

ex: https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/improvers/valid_versions.py#L472

ambuj-1211 · 2024-04-10T09:12:48Z

work! just a few nits for your consi

I think you tagged someone else in this comment, is it a mistake?
And I am working on the changes now.

ziadhany · 2024-04-10T13:53:56Z

work! just a few nits for your consi

I think you tagged someone else in this comment, is it a mistake?
And I am working on the changes now.

sorry it was a mistake and I fixed it

ambuj-1211 · 2024-04-12T18:34:50Z

@ziadhany please review the changes and do let me know.

ziadhany

Great work! please fix those failing tests then squash the commits

vulnerabilities/importers/curl.py

ambuj-1211 · 2024-04-13T01:52:29Z

@ziadhany I made the changes, should I also update my branch?

ziadhany · 2024-04-13T16:24:50Z

@ambuj-1211 Absolutely! Once all the changes are in place, squashing them into a single commit before merging will create a cleaner history for everyone.

to fix the test update the vulnerabilities/tests/test_data/curl/expected-curl-advisory-output.json
and it would be good if you add more test examples :
vulnerabilities/tests/test_data/curl/expected-curl-advisory-output1.json
vulnerabilities/tests/test_data/curl/expected-curl-advisory-output2.json

ambuj-1211 · 2024-05-07T18:32:45Z

@ziadhany @TG1999 i have made all the required changes and squashed all the commits to make the history clean, moreover I also had updated my branch according to the main branch.
Please review it.

ambuj-1211 · 2024-05-09T15:21:21Z

@ziadhany some checks are not successfull but they are because of openssl url do I need to change it to some thing, I am asking because it is not related to curl advisories.

ziadhany · 2024-05-09T16:53:08Z

@ziadhany some checks are not successfull but they are because of openssl url do I need to change it to some thing, I am asking because it is not related to curl advisories.

@ambuj-1211 No, this is the docs test ( not related to this pull request )

ambuj-1211 · 2024-05-09T17:04:02Z

so this pr is good to go?

ziadhany

LGTM, just a minor nit for your consideration

vulnerabilities/tests/test_data/curl/expected_curl_advisory_output3.json

vulnerabilities/importers/curl.py

- added curl importer - added tests for curl importer Signed-off-by: ambuj <[email protected]>

ambuj-1211 · 2024-05-10T13:29:16Z

@ziadhany check the files now I have changed the files and squashed the commits, I think now the history and everything is clean and good to go, please let me know if there are any more nits.

…l importer. Signed-off-by: ambuj <[email protected]>

TG1999 · 2024-07-22T15:21:55Z

@ambuj-1211 please resolve conflicts on this PR

TG1999 · 2024-07-22T15:22:27Z

@ziadhany is this PR good to merge, if yes please merge this in. Thanks!

ziadhany · 2024-07-23T06:45:36Z

@ziadhany is this PR good to merge, if yes please merge this in. Thanks!

@TG1999 Yes, I have reviewed this pull request several times and I believe we should merge it.

TG1999 · 2024-08-06T08:14:58Z

@ambuj-1211 please see tests are failing

Signed-off-by: ambuj <[email protected]>

ambuj-1211 · 2024-08-20T12:20:19Z

corrected the code now check @TG1999

ziadhany

@ambuj-1211 LGTM, Just remove the unused importer and squash the commits.

vulnerabilities/importers/curl.py

Signed-off-by: ambuj <[email protected]>

ambuj-1211 · 2024-09-10T16:14:58Z

@TG1999 please have a look on the log file
curlimporterlogs.txt

TG1999 · 2024-09-12T10:59:20Z

@ambuj-1211 thanks! merged!

ziadhany requested changes Mar 25, 2024

View reviewed changes

vulnerabilities/tests/test_curl.py Outdated Show resolved Hide resolved

vulnerabilities/importers/curl.py Outdated Show resolved Hide resolved

ziadhany requested changes Apr 9, 2024

View reviewed changes

ziadhany requested changes Apr 12, 2024

View reviewed changes

vulnerabilities/importers/curl.py Outdated Show resolved Hide resolved

ambuj-1211 force-pushed the add-curl-advisories-importer branch from 2f84bec to 5ae6ac0 Compare May 7, 2024 18:26

ziadhany requested changes May 9, 2024

View reviewed changes

vulnerabilities/tests/test_data/curl/expected_curl_advisory_output3.json Outdated Show resolved Hide resolved

vulnerabilities/importers/curl.py Show resolved Hide resolved

ambuj-1211 force-pushed the add-curl-advisories-importer branch 2 times, most recently from f2729d8 to c9ebb70 Compare May 10, 2024 13:12

Add curl advisories

24b5eaa

- added curl importer - added tests for curl importer Signed-off-by: ambuj <[email protected]>

ambuj-1211 force-pushed the add-curl-advisories-importer branch from c9ebb70 to 24b5eaa Compare May 10, 2024 13:19

ambuj-1211 force-pushed the add-curl-advisories-importer branch from a5b0752 to cb4ca3e Compare June 3, 2024 20:04

Fix: Change severity versions from generic textual to cvssv3.1 in cur…

fcd4c0c

…l importer. Signed-off-by: ambuj <[email protected]>

ambuj-1211 force-pushed the add-curl-advisories-importer branch from cb4ca3e to fcd4c0c Compare June 6, 2024 11:16

Merge branch 'main' into add-curl-advisories-importer

4b1aae7

Merge branch 'main' into add-curl-advisories-importer

561272c

ambuj-1211 added 4 commits August 6, 2024 17:26

Merge branch 'main' into add-curl-advisories-importer

91e3e57

Merge branch 'aboutcode-org:main' into add-curl-advisories-importer

aecd137

Merge branch 'aboutcode-org:main' into add-curl-advisories-importer

87d0388

correct unit test and doctest for curl importer

09eb475

Signed-off-by: ambuj <[email protected]>

AyanSinhaMahapatra requested review from ziadhany and TG1999 August 26, 2024 14:58

ziadhany reviewed Aug 30, 2024

View reviewed changes

vulnerabilities/importers/curl.py Outdated Show resolved Hide resolved

ambuj-1211 and others added 3 commits September 2, 2024 18:37

Merge branch 'main' into add-curl-advisories-importer

a7b81e2

remove unused imports

c398d83

Signed-off-by: ambuj <[email protected]>

Merge branch 'main' into add-curl-advisories-importer

9bc32c1

TG1999 merged commit 3c5289e into aboutcode-org:main Sep 12, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add curl advisories importer #1439

Add curl advisories importer #1439

ambuj-1211 commented Mar 17, 2024

ambuj-1211 commented Mar 17, 2024

ziadhany left a comment •

edited

Loading

ambuj-1211 commented Mar 31, 2024

ambuj-1211 commented Apr 7, 2024

ziadhany left a comment •

edited

Loading

ziadhany commented Apr 9, 2024

ambuj-1211 commented Apr 10, 2024 •

edited by ziadhany

Loading

ziadhany commented Apr 10, 2024

ambuj-1211 commented Apr 12, 2024

ziadhany left a comment

ambuj-1211 commented Apr 13, 2024

ziadhany commented Apr 13, 2024 •

edited

Loading

ambuj-1211 commented May 7, 2024

ambuj-1211 commented May 9, 2024

ziadhany commented May 9, 2024 •

edited

Loading

ambuj-1211 commented May 9, 2024

ziadhany left a comment

ambuj-1211 commented May 10, 2024

TG1999 commented Jul 22, 2024

TG1999 commented Jul 22, 2024

ziadhany commented Jul 23, 2024 •

edited

Loading

TG1999 commented Aug 6, 2024

ambuj-1211 commented Aug 20, 2024

ziadhany left a comment

ambuj-1211 commented Sep 10, 2024

TG1999 commented Sep 12, 2024

Add curl advisories importer #1439

Add curl advisories importer #1439

Conversation

ambuj-1211 commented Mar 17, 2024

ambuj-1211 commented Mar 17, 2024

ziadhany left a comment • edited Loading

Choose a reason for hiding this comment

ambuj-1211 commented Mar 31, 2024

ambuj-1211 commented Apr 7, 2024

ziadhany left a comment • edited Loading

Choose a reason for hiding this comment

ziadhany commented Apr 9, 2024

ambuj-1211 commented Apr 10, 2024 • edited by ziadhany Loading

ziadhany commented Apr 10, 2024

ambuj-1211 commented Apr 12, 2024

ziadhany left a comment

Choose a reason for hiding this comment

ambuj-1211 commented Apr 13, 2024

ziadhany commented Apr 13, 2024 • edited Loading

ambuj-1211 commented May 7, 2024

ambuj-1211 commented May 9, 2024

ziadhany commented May 9, 2024 • edited Loading

ambuj-1211 commented May 9, 2024

ziadhany left a comment

Choose a reason for hiding this comment

ambuj-1211 commented May 10, 2024

TG1999 commented Jul 22, 2024

TG1999 commented Jul 22, 2024

ziadhany commented Jul 23, 2024 • edited Loading

TG1999 commented Aug 6, 2024

ambuj-1211 commented Aug 20, 2024

ziadhany left a comment

Choose a reason for hiding this comment

ambuj-1211 commented Sep 10, 2024

TG1999 commented Sep 12, 2024

ziadhany left a comment •

edited

Loading

ziadhany left a comment •

edited

Loading

ambuj-1211 commented Apr 10, 2024 •

edited by ziadhany

Loading

ziadhany commented Apr 13, 2024 •

edited

Loading

ziadhany commented May 9, 2024 •

edited

Loading

ziadhany commented Jul 23, 2024 •

edited

Loading