Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly state app name in TestMigration #1012

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

JonoYang
Copy link
Member

* The code used to determine the name of the django app to perform test migrations on is a bit arcane
* By explicitly stating the app name, you can move the data migration test file to any location

Signed-off-by: Jono Yang [email protected]

    * The code used to determine the name of the django app to perform test migrations on is a bit arcane
    * By explicitly stating the app name, you can move the data migration test file to any location

Signed-off-by: Jono Yang <[email protected]>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pombredanne pombredanne merged commit d19a78e into main Nov 28, 2022
@pombredanne pombredanne deleted the data-migration-test-code-explicitly-state-app branch November 28, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants