Retrun list in get_package_versions

Signed-off-by: Keshav Priyadarshi <[email protected]>
aboutcode-org · Dec 20, 2023 · 2146ec4 · 2146ec4
1 parent 85f7873
commit 2146ec4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/vulnerabilities/improvers/valid_versions.py b/vulnerabilities/improvers/valid_versions.py
@@ -69,11 +69,11 @@ def get_package_versions(
         Return a list of versions published before `until` for the `package_url`
         """
         versions = package_versions.versions(str(package_url))
-        versions_before_until = set()
+        versions_before_until = []
         for version in versions or []:
             if until and version.release_date and version.release_date > until:
                 continue
-            versions_before_until.add(version.value)
+            versions_before_until.append(version.value)
 
         return versions_before_until
 

diff --git a/vulnerabilities/tests/test_github.py b/vulnerabilities/tests/test_github.py
@@ -285,7 +285,7 @@ def test_get_package_versions(mock_response):
         mock_response.return_value = json.load(f)
 
     improver = GitHubBasicImprover()
-    valid_versions = {
+    valid_versions = [
         "1.1.3",
         "1.1.4",
         "1.10",
@@ -300,11 +300,12 @@ def test_get_package_versions(mock_response):
         "1.10a1",
         "1.10b1",
         "1.10rc1",
-    }
-    assert (
+    ]
+    result = sorted(
         improver.get_package_versions(package_url=PackageURL(type="pypi", name="django"))
-        == valid_versions
     )
+    expected = sorted(valid_versions)
+    assert result == expected
 
 
 def test_get_cwes_from_github_advisory():