Add children_packages m2m and rename resolved_to_package #1066 #1252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved_to
toresolved_to_package
, andresolved_dependencies
toresolved_from_dependencies
for clarity and consistency.children_packages
andparent_packages
ManyToMany field on the DiscoveredPackage model.We now have:
DiscoveredDependency.for_package
: The package that declares this dependency.DiscoveredDependency.resolved_to_package
: The resolved package for this dependency. If empty, it indicates the dependency is unresolved.DiscoveredPackage.children_packages
: List of direct dependency packages.DiscoveredPackage.parent_packages
: List of direct parent packages.DiscoveredPackage.declared_dependencies
: List of declared dependencies in this package.DiscoveredPackage.resolved_from_dependencies
: List of dependencies resolved from this package.You'll notice that field names are now explicit and consistent:
*_package
is a package instance*_packages
is a package queryset*_dependency
is a dependency instance*_dependencies
is a dependency queryset@pombredanne @AyanSinhaMahapatra @Hritik14 Please have a look at those changes and additions and let me know you thoughts.