Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new licenses #3778

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Add new licenses #3778

merged 5 commits into from
Jun 12, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

These were added by @DennisClark

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra
Add new licenses
31f1668 
These were added by @DennisClark

Reference: #3782
Reference: #3774
Reference: #3760
Reference: #3759
Reference: #3758
Reference: #3733
Reference: #3732
Reference: #3708
Reference: #3692
Reference: #3691
Reference: #3684
Reference: #3657
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
pombredanne approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few minor nits that are not essential

src/licensedcode/data/licenses/rh-eula-lgpl.LICENSE Show resolved Hide resolved
src/licensedcode/data/licenses/rsalv2.LICENSE Show resolved Hide resolved
src/licensedcode/data/licenses/rh-eula.LICENSE Show resolved Hide resolved
src/licensedcode/data/licenses/saxix-mit.LICENSE Outdated Show resolved Hide resolved
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 588d32b into develop Jun 12, 2024
28 of 34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the new-licenses branch June 12, 2024 15:26
@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Jun 12, 2024 •
edited
Loading

Merged, thanks a lot for reporting these @LeChasseur @armijnhemel, @pabs3 and @pombredanne and thanks for adding these @DennisClark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne