Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSFT related URL rules #3717

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

swastkk
Copy link
Collaborator

@swastkk swastkk commented Apr 1, 2024

Fixes #3702

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what we want to do, see comments.

https://dotnet.microsoft.com/en-us/dotnet_library_license.htm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've misunderstood entirely what we want to do here.

We don't want to change the rule text, we want to change the license_expression for this rule to ms-net-library-2019-06 as this is a license we now have in licenseDB and so this is not an unknown license reference.

Note that we cannot just change a license-expression by replacing, we have to deprecate this rule and create a new rule, see the comment in #3744 (comment) for example. As this is reference data and we want to preserve these rule names and links to these.

@pombredanne
Copy link
Member

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and use correct license for MSFT related URL rules
3 participants