-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License improvement winter 2022 #2828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #2819 Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
license-improvement-winter-2022
branch
from
February 1, 2022 21:32
b50831b
to
d40c65f
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reported-by: DennisClark @DennisClark Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
x11-xconsortium_veillard was using an underscore which is not SPDX friendly and is now deprecated. x11-xconsortium-veillard is the new key Reference: #2813 Reported-by: Frank Viernau <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Keeping these under 50 characters is a sane thing to do. Otherwise DBs that have a license key with 50 chars are not super happy. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Thank-you-to: Steve Winslow <[email protected]> @swinslow Signed-off-by: Philippe Ombredanne <[email protected]>
We now have a named license for this Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Keeping these under 50 characters is a sane thing to do. Otherwise DBs that have a license key field with 50 chars are not super happy. Signed-off-by: Philippe Ombredanne <[email protected]>
Add new language attribute to a Rule, deafulting to English. Use proper language tags and SPDX ids for licenses that were kept back. Reference: #139 Signed-off-by: Philippe Ombredanne <[email protected]>
Add language attributes to rules Move all non-english licenses to the main directory Fix duplicates rules and licenses Add new command line option to index with non-english licenses. This is experimental. Add check for long SPDX license keys Reference: #139 Signed-off-by: Philippe Ombredanne <[email protected]>
Remove all license cache code checking and validation. This is a complex and overengineered feature that is only useful for developers. They can run the --reindex-licenses instead as needed. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
With this new include_ignorables argument, License.to_dict() can optionally skip ignrable_* attributes. Signed-off-by: Philippe Ombredanne <[email protected]>
With this new include_text argument, License.to_dict() can optionally include the full license text Signed-off-by: Philippe Ombredanne <[email protected]>
The new --licenses-reference option adds a new "licenses_reference" top level attribute to a scan seen in the JSON and YAML attribute. This contains all the license details. Also bump the WIP version. Reference: #1697 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Align with the latest license updates. Signed-off-by: Philippe Ombredanne <[email protected]>
Check the correct checksum when no rebuild is requested Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Align with the latest license updates. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #139 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
license-improvement-winter-2022
branch
from
February 10, 2022 23:07
646b260
to
4298481
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Use better text formatting and remove extra non-text comments Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is a batch of misc. rules from actual motices or references seen in the wild. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is marked as expected failure for now until we have proper ways to combine multiple detections. Signed-off-by: Philippe Ombredanne <[email protected]>
It already exists in the main branch Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
By checking that we have a proper public suffix domain, we avoid many junk emails. Reference: #2810 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
All green now... so merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Run tests locally to check for errors.