Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always collect full stack trace for scan errors #784

Closed
pombredanne opened this issue Oct 3, 2017 · 3 comments
Closed

Always collect full stack trace for scan errors #784

pombredanne opened this issue Oct 3, 2017 · 3 comments
Labels
core and api enhancement GUI and outputs must have

Comments

@pombredanne
Copy link
Member

Scan errors should come always with a full stack trace for diagnostic, being forced to use the --diag option is not a great solution as these may be hard to reproduce at times.
@yash-nisar
Copy link
Contributor

I would like to work on this issue. :)

@yash-nisar
Copy link
Contributor

yash-nisar commented Feb 6, 2018 •
edited
Loading

So, if I understand correctly, we have to always show a full stack trace for scan errors. This would mean that we still keep the --diag option as it is used to show additional match details in case of licenses, but show the full stack trace even in case of a simple error without the --diag flag. Please correct me if I am wrong @pombredanne :)

yash-nisar added a commit to yash-nisar/scancode-toolkit that referenced this issue Feb 6, 2018
@yash-nisar
Collect full stack trace for scan errors aboutcode-org#784
340b0c2 
Scan errors are now shown with a full stack trace for diagnosis
and no longer require the `--diag` option.

Signed-off-by: Yash Nisar <[email protected]>
yash-nisar added a commit to yash-nisar/scancode-toolkit that referenced this issue Feb 6, 2018
@yash-nisar
Collect full stack trace for scan errors aboutcode-org#784
a67dbfa 
Scan errors are now shown with a full stack trace for diagnosis
and no longer require the `--diag` option.

Signed-off-by: Yash Nisar <[email protected]>
@yash-nisar yash-nisar mentioned this issue Feb 6, 2018
Closed
@pombredanne
Copy link
Member Author

Merged in develop with #885 ... @yash-nisar Thanks for looking at this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core and api enhancement GUI and outputs must have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @yash-nisar