New settings module for python inspector #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocastro
commented
Nov 14, 2024
heliocastro
commented
- Create default settings class based on pydantic-settings with validation
- Update minimum python requirement to 3.9 as 3.9 is EOL
- Refactor code to match new settings class
- Modify tests to use new settings class
Settings can now be defined through environment variables, .env local file or regular arguments to the script. All variables need to be prefixed by PYTHON_INSPECTOR_ to be recognized. Example: PYTHON_INSPECTOR_INDEX_URL="https://pypy1.org,https://foo.bar" will add this two repositories overriding the public repository. Raise the minimum python version to 3.9 as 3.8 is EOL. Signed-off-by: Helio Chissini de Castro <[email protected]>
Signed-off-by: Helio Chissini de Castro <[email protected]>
Signed-off-by: Helio Chissini de Castro <[email protected]>
- Downgrade dataclasses to version 0.6, as last supported to python 3.9 - Update mypy to version 1.0.0 Signed-off-by: Helio Chissini de Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.