Replace packaging with packvers #108 #109

swastkk · 2023-01-03T04:33:38Z

Packvers added in resolution.py and changed the version of pip-requirments-parser too.
for the aboutcode-org/scancode.io#576 and #108 issue as well.
Signed-off-by: Swastik Sharma [email protected]

swastkk · 2023-01-03T19:48:06Z

After analysing I found that due to that change in Packvers, we need to update our https://github.com/nexB/dparse2 for packvers and packaging change in the release and https://github.com/nexB/pip-requirements-parser to in the release , after that this PR will have all Test pass
Signed-off-by: swastik [email protected]

pombredanne

Thank you ++ !

"Packvers added" may not be the best name for this PR. What about "Replace packaging with packvers" instead?

Also on the commit message style, your use of things such as "packaging-to-packvers-done-in-resolution.py" may not be something we typically use... look for other commit messages for inspiration and also at https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

See also the other review comments I posted for your kind consideration.

etc/scripts/utils_dejacode.py

src/_packagedcode/pypi.py

setup.cfg

swastkk · 2023-01-05T19:38:49Z

Thank you ++ !

"Packvers added" may not be the best name for this PR. What about "Replace packaging with packvers" instead?

Also on the commit message style, your use of things such as "packaging-to-packvers-done-in-resolution.py" may not be something we typically use... look for other commit messages for inspiration and also at https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

See also the other review comments I posted for your kind consideration.

Okay sure will change accordingly : )

pombredanne

Thank you ... here are some review comments

etc/scripts/utils_pip_compatibility_tags.py

etc/scripts/utils_thirdparty.py

src/python_inspector/utils_pypi.py

CHANGELOG.rst

src/python_inspector/api.py

pombredanne

Thank you for the updates. Do you mind to squash your commits in a single commit with a good commit message?

pombredanne

LGTM and ready to merge once squashed!

swastkk · 2023-01-11T10:23:27Z

LGTM and ready to merge once squashed!

Done ✔️, can merge now :")

pombredanne · 2023-01-11T22:13:36Z

@swastkk you did not squash it all in one commit, you still have 15 commits... you squash and force push. https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

swastkk · 2023-01-12T02:31:54Z

@swastkk you did not squash it all in one commit, you still have 15 commits... you squash and force push. https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

Is it okay now??

pombredanne

Thanks!
Can you make one last change and amend your commit?

We want to subject to be using imperative style (e.g., Replace not Replaced) and to be subject line must be under 50 characters and ew extra things to review at https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

swastkk · 2023-01-12T14:01:15Z

Thanks! Can you make one last change and amend your commit?

We want to subject to be using imperative style (e.g., Replace not Replaced) and to be subject line must be under 50 characters and ew extra things to review at https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

Now?

pombredanne

Thanks!
"Replace packaging with packvers and bump packages version" is still at 57 chars... can you do something more or less like this instead:

Replace packaging library with packvers #108

Work around changes in packaging by replacing it with packvers
to avoid issues with missing packaging.version.LegacyVersion.

Also bump the versions of dparse2 and pip-requirements-parser
with new versions that are not subject the LegcacyVersion issue.

Adjust the code and tests accordingly.

Reference: https://github.com/nexB/python-inspector/issues/108
Reference: https://github.com/pypa/packaging/issues/530
Signed-off-by: swastik <[email protected]>

And please remove all changes you made that are not strictly about this... I am not sure what happened but you end up with unrelated changes. Do not hesitate to ask for help on the Gitter chat!

Thanks again for your preseverance.

CHANGELOG.rst

src/python_inspector/api.py

src/python_inspector/resolve_cli.py

pombredanne

Thanks for the update. One last nit before we can merge.

src/_packagedcode/pypi.py

pombredanne

Here are a few last nits.

src/_packagedcode/pypi.py

setup.cfg

src/_packagedcode/pypi.py

* Work around changes in packaging by replacing it with packvers to avoid issues with missing packaging.version.LegacyVersion. * Also bump the versions of dparse2 and pip-requirements-parser with new versions that are not subject the LegcacyVersion issue. * Adjust the code and tests accordingly. Reference: aboutcode-org#108 Reference: pypa/packaging#530 Signed-off-by: swastik <[email protected]>

pombredanne

All good .... Thank you ++

swastkk force-pushed the packvers-added branch 2 times, most recently from a04b5f4 to e7baa79 Compare January 3, 2023 19:39

This was referenced Jan 4, 2023

packvers-imports-instead-of-packaging aboutcode-org/pip-requirements-parser#14

Closed

Need a release of dparse2 asap. aboutcode-org/dparse2#6

Closed

pombredanne requested changes Jan 5, 2023

View reviewed changes

etc/scripts/utils_dejacode.py Outdated Show resolved Hide resolved

src/_packagedcode/pypi.py Show resolved Hide resolved

setup.cfg Outdated Show resolved Hide resolved

swastkk changed the title ~~Packvers added~~ Replace packaging with packvers Jan 5, 2023

swastkk mentioned this pull request Jan 5, 2023

Replace packaging with packvers in src/scripts aboutcode-org/skeleton#71

Merged

swastkk force-pushed the packvers-added branch from 4196298 to 862f00b Compare January 10, 2023 05:19

pombredanne requested changes Jan 10, 2023

View reviewed changes

pombredanne requested changes Jan 11, 2023

View reviewed changes

pombredanne reviewed Jan 11, 2023

View reviewed changes

swastkk requested a review from pombredanne January 11, 2023 20:01

swastkk force-pushed the packvers-added branch from e11872c to eae13cf Compare January 12, 2023 02:30

pombredanne requested changes Jan 12, 2023

View reviewed changes

swastkk force-pushed the packvers-added branch from eea5a58 to 1999fdc Compare January 12, 2023 13:59

swastkk changed the title ~~Replace packaging with packvers~~ Replace packaging with packvers to issue https://github.com/nexB/python-inspector/issues/108 Jan 12, 2023

swastkk changed the title ~~Replace packaging with packvers to issue https://github.com/nexB/python-inspector/issues/108~~ Replace packaging with packvers to issue #108 Jan 12, 2023

swastkk changed the title ~~Replace packaging with packvers to issue #108~~ Replace packaging with packvers (issue #108) Jan 12, 2023

pombredanne requested changes Jan 12, 2023

View reviewed changes

swastkk force-pushed the packvers-added branch 3 times, most recently from 53934bf to 2a36d33 Compare January 12, 2023 16:32

swastkk requested a review from pombredanne January 12, 2023 22:10

pombredanne requested changes Jan 12, 2023

View reviewed changes

src/_packagedcode/pypi.py Show resolved Hide resolved

pombredanne changed the title ~~Replace packaging with packvers (issue #108)~~ Replace packaging with packvers #108 Jan 12, 2023

swastkk force-pushed the packvers-added branch 2 times, most recently from ea761e5 to 0bdaa36 Compare January 13, 2023 08:58

pombredanne requested changes Jan 13, 2023

View reviewed changes

src/_packagedcode/pypi.py Show resolved Hide resolved

setup.cfg Outdated Show resolved Hide resolved

pombredanne reviewed Jan 13, 2023

View reviewed changes

src/_packagedcode/pypi.py Outdated Show resolved Hide resolved

swastkk force-pushed the packvers-added branch from 0bdaa36 to 6579412 Compare January 13, 2023 16:02

AyanSinhaMahapatra mentioned this pull request Jan 13, 2023

Fix dependency issues aboutcode-org/scancode.io#586

Merged

pombredanne approved these changes Jan 13, 2023

View reviewed changes

pombredanne merged commit e1ffca1 into aboutcode-org:main Jan 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace packaging with packvers #108 #109

Replace packaging with packvers #108 #109

swastkk commented Jan 3, 2023 •

edited

Loading

swastkk commented Jan 3, 2023

pombredanne left a comment

swastkk commented Jan 5, 2023

pombredanne left a comment

pombredanne left a comment

pombredanne left a comment

swastkk commented Jan 11, 2023

pombredanne commented Jan 11, 2023

swastkk commented Jan 12, 2023

pombredanne left a comment

swastkk commented Jan 12, 2023

pombredanne left a comment

pombredanne left a comment

pombredanne left a comment

pombredanne left a comment

Replace packaging with packvers #108 #109

Replace packaging with packvers #108 #109

Conversation

swastkk commented Jan 3, 2023 • edited Loading

swastkk commented Jan 3, 2023

pombredanne left a comment

Choose a reason for hiding this comment

swastkk commented Jan 5, 2023

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

swastkk commented Jan 11, 2023

pombredanne commented Jan 11, 2023

swastkk commented Jan 12, 2023

pombredanne left a comment

Choose a reason for hiding this comment

swastkk commented Jan 12, 2023

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

swastkk commented Jan 3, 2023 •

edited

Loading