Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tool_version key/value pairs from tests #296 #297

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

johnmhoran
Copy link
Member

Reference: #296

I've used from scancode import cli_test_utils -- e.g., cli_test_utils.streamline_headers(output_data["headers"]) -- to remove the tool_version key/value pair from expected and actual test data and removed tests that checked the tool_version.

Reference: #296

Signed-off-by: John M. Horan <[email protected]>
@johnmhoran
Copy link
Member Author

@pombredanne I have more work to do on the validate and versions code and tests (and one more test for urls) and plan to open a new branch for that work -- treating this PR, branch and issue as free-standing so we can address the dynamic test tool_version values right away. Please let me know if you'd prefer that I also use this branch and PR for that upcoming code/test work.

@pombredanne
Copy link
Member

Thanks. You should copy cli_test_utils.py here instead.
ScanCode is not a dep of this toolkit (and we do not want it to be such a dep for now)
We likely will need to adjust the tests so they run in isolation from the main purldb code.

@johnmhoran
Copy link
Member Author

@pombredanne I've copied cli_test_utils.py from ScanCode to purldb_toolkit; all GH checks have passed (and all 76 local purlcli tests passed as well). Do you want to treat this as a free-standing issue/PR and merge when ready (my suggestion), or shall I use this for my ongoing purlcli code/test work?

@johnmhoran
Copy link
Member Author

LGTM ;-) Merging.

@johnmhoran johnmhoran merged commit 1272a61 into main Feb 21, 2024
7 checks passed
@johnmhoran johnmhoran deleted the 296-remove-tool-version-from-tests branch February 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants